cqssrt log field for TLS resumption type - #12404
Merged
Merged
Conversation
bneradt
force-pushed
the
cqssrt_log_field
branch
2 times, most recently
from
July 29, 2025 23:26
22e113e to
6a2002a
Compare
bneradt
force-pushed
the
cqssrt_log_field
branch
from
September 22, 2025 14:10
6a2002a to
1c35f44
Compare
bneradt
marked this pull request as ready for review
September 22, 2025 14:11
maskit
reviewed
Sep 24, 2025
maskit
previously approved these changes
Sep 24, 2025
This adds the cqssrt log field that indicates the TLS resumption type: 0: no resumption 1: server session cache resumption 2: TLS ticket resumption
bneradt
force-pushed
the
cqssrt_log_field
branch
from
September 24, 2025 19:00
1c35f44 to
3faef82
Compare
maskit
approved these changes
Sep 24, 2025
masaori335
added a commit
that referenced
this pull request
Jul 7, 2026
The cqssrt (client_req_ssl_resumption_type) log field added in #12404 was silently dropped from master by the 11-Dev integration merge (#12983, 8415cef). A criss-cross merge resolution removed its registration in Log.cc and the LogAccess marshal path, while the supporting HttpUserAgent::get_client_ssl_resumption_type() machinery survived, leaving that accessor as dead code with no caller. Re-register the field and re-add the marshal function plus the TransactionLogData bridge accessor so the orphaned machinery is wired back into the log system. Declare it as sINT (it marshals a single int), not the original dINT, matching the type/marshal-framing fix in #13223.
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jul 29, 2026
The cqssrt (client_req_ssl_resumption_type) log field added in apache#12404 was silently dropped from master by the 11-Dev integration merge (apache#12983, 8415cef). A criss-cross merge resolution removed its registration in Log.cc and the LogAccess marshal path, while the supporting HttpUserAgent::get_client_ssl_resumption_type() machinery survived, leaving that accessor as dead code with no caller. Re-register the field and re-add the marshal function plus the TransactionLogData bridge accessor so the orphaned machinery is wired back into the log system. Declare it as sINT (it marshals a single int), not the original dINT, matching the type/marshal-framing fix in apache#13223.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the cqssrt log field that indicates the TLS resumption type:
0: no resumption
1: server session cache resumption
2: TLS ticket resumption